Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chal 16 #27

Merged
merged 11 commits into from
Aug 18, 2024
Merged

Chal 16 #27

merged 11 commits into from
Aug 18, 2024

Conversation

noreen1423
Copy link
Contributor

Checklist

Please ensure you have followed all of the steps below before submitting a pull request:

  • Include the corresponding Jira issue key and #done in the PR title, like so: "CHAL-32 #Take the Challenge buttons on home page should send the user to /challengerwelcome"
  • Verify that the code compiles (npm run dev)
  • Verify that the project builds (npm run build)
  • Verify that all tests pass
  • Verify that unit tests cover 100% of the code
  • Create Storybook stories for visual components
  • Verify that any visual components match the Figma
  • Test with a screen reader (if applicable)
  • Document your code with TSDoc comments
  • Format your code with Prettier

Overview

REQUIRED
Fill in the overview of this PR, what this PR is trying to achieve.

Test Plan

REQUIRED
What you did to verify your PR works as claimed? Make sure to list things/steps/screenshots/screentcasts so that others can reproduce your test easily. Share styling changes and component updates through screenshots.

Follow ups

It is okay for the PR to be not perfect, list what you/other should work on after this PR is merged.

dvorakjt
dvorakjt requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@dvorakjt dvorakjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Noreen,

Looks great! Only two things:

  • Please fetch and merge the latest changes in from upstream/development and then push these changes to your fork
  • Please remove the data-testid prop from the PageContainer component as this is unused. Then regenerate the snapshots by running npm test -- -u

This is great, thank you!

src/components/utils/page-container/page-container.tsx Outdated
@@ -7,7 +7,7 @@ import styles from './styles.module.scss';
*/
export function PageContainer({ children }: PropsWithChildren) {
return (
<div className={styles.outer_container}>
<div className={styles.outer_container} data-testid="page-container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove data-testid here as it is unused.

dvorakjt
dvorakjt approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@dvorakjt dvorakjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, approved!

@dvorakjt dvorakjt merged commit 816fc1e into 8by8-org:development Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvorakjt dvorakjt dvorakjt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noreen1423 @dvorakjt